萤火虫之光

十四

如你所知，萤火虫之光最近重置了，现在它给予1.3的回魔和14攻击，并且击杀和助攻能积累物理伤害
当我检查脚本的时候我发现有趣的事

它仍然能减免DEBUFF35%的持续时间
function DebuffDuration takes unit target, real time returns real
// . . .

elseif UnitHasItemOfTypeBJ(target, 'I07Z') then
    set time = time * 0.65
endif

// . . .
endfunction
它能减少25%晕眩
function GetUnitControlAllReduce takes unit caster, unit target returns real
// . . .

if UnitHasItemOfTypeBJ(target, 'I07Z') then
    set timeper = timeper * 0.75
endif

// . . .
endfunction
物品数据里的规定没变（跟最近版本无关）【这个意思不太对】
call ItemRegisterDataDefence('I07Z', 6000, 0, 0, 0, 0, 0, 0, 0)
call ItemRegisterDataAttack('I07Z', 0, 0, 0, 0, 0, 0)
call ItemRegisterDataStat('I07Z', 21, 21, 21)
不管怎样我没看见这件物品有对应“加回魔”和“加攻击”的项目
怎么修

移除“debuff时间”和“晕眩时间”项目中的的规定【declarations】

更改物品基本数据里的属性
call ItemRegisterDataDefence('I07Z', 2000, 0, 0, 0, 1.3, 0, 0, 0)
call ItemRegisterDataAttack('I07Z', 14, 0, 0, 0, 0, 0)
call ItemRegisterDataStat('I07Z', 0, 0, 0)
加入“给予攻击”和“给予回魔”项目的规定
function GetUnitItemAttackCharges takes unit v, integer itemr returns real
    local integer i = 0
    local real attack = 0.0
    loop
        if GetItemTypeId(UnitItemInSlot(v, i)) == itemr then
            set attack = attack + GetItemCharges(UnitItemInSlot(v, i))
        endif
        set i = i + 1
        exitwhen i > 6
    endloop
    return attack
endfunction

function GetUnitAttack takes unit v returns integer
// . . .

    set attack = attack + GetUnitItemAttack(v, 'I07Z', 14)
    set attack = attack + GetUnitItemAttackCharges(v, 'I07Z')

// . . .
endfunction
function GetUnitMagicRegen takes unit v returns real
// . . .

    set regen = regen + GetUnitItemMagicRegen_Single(v, 'I07Z', 1.30)

// . . .
endfunction
以上

沧海求援

GOOD JOB

老外真给力{:4_134:}

swdn

THD_988h final.w3x

The code is still here:

1. 
   
2. function GetUnitControlAllReduce takes unit caster, unit target returns real
   
3.     // . . .
   
4.     if UnitHasItemOfTypeBJ(target, 'I07Z') then
   
5.         set timeper = timeper * 0.75
   
6.     endif
   
7.     // . . .
   
8. endfunction
   

复制代码

It should be removed.

Also:

1. 
   
2. function GetUnitAttack takes unit v returns integer
   
3.     // . . .
   
4.     set attack = attack + udg_DMG_AllItemArmor[GetPlayerId(GetOwningPlayer(v))]
   
5.     return R2I(attack)
   
6. endfunction
   

复制代码

should be changed to:

1. 
   
2. function GetUnitAttack takes unit v returns integer
   
3.     // . . .
   
4.     set attack = attack + udg_DMG_AllItemAttack[GetPlayerId(GetOwningPlayer(v))]
   
5.     set attack = attack + UnitGetBonusDmg(v) // this is important
   
6.     return R2I(attack)
   
7. endfunction
   

复制代码

Adding "UnitGetBonusDmg" is important. This function returns bonus attack damage, that can be changed dynamically (bonus damage is used in [萤火虫之光], [厄运的护符], Rumia [W], Momiji [D], etc.)

Thanks.

swdn

Hello.

As you know, the item "Light of the Fireflies" [萤火虫之光] (code 'I07Z') has been remade recently. Now it gives +1.3 mana regen and +14 damage. Also, killing or assisting gives stacks for attack damage.

When I decided to check the script, I've found some interesting things.

It still decreases duration of debuffs by 35%:

1. 
   
2. function DebuffDuration takes unit target, real time returns real
   
3. // . . .
   
4. 
   
5. elseif UnitHasItemOfTypeBJ(target, 'I07Z') then
   
6.     set time = time * 0.65
   
7. endif
   
8. 
   
9. // . . .
   
10. endfunction
    

复制代码

It reduces stun duration by 25%:

1. 
   
2. function GetUnitControlAllReduce takes unit caster, unit target returns real
   
3. // . . .
   
4. 
   
5. if UnitHasItemOfTypeBJ(target, 'I07Z') then
   
6.     set timeper = timeper * 0.75
   
7. endif
   
8. 
   
9. // . . .
   
10. endfunction
    

复制代码

Stats in item database have not changed (does not matter in current version):

1. 
   
2. call ItemRegisterDataDefence('I07Z', 6000, 0, 0, 0, 0, 0, 0, 0)
   
3. call ItemRegisterDataAttack('I07Z', 0, 0, 0, 0, 0, 0)
   
4. call ItemRegisterDataStat('I07Z', 21, 21, 21)
   

复制代码

However, I did not see declarations for this item in functions "GetUnitAttack" and "GetUnitMagicRegen".

How to fix:

- Remove declarations from "DebuffDuration" and "GetUnitControlAllReduce" functions

- Change stats in item database:

1. 
   
2. call ItemRegisterDataDefence('I07Z', 2000, 0, 0, 0, 1.3, 0, 0, 0)
   
3. call ItemRegisterDataAttack('I07Z', 14, 0, 0, 0, 0, 0)
   
4. call ItemRegisterDataStat('I07Z', 0, 0, 0)
   

复制代码

- Add declarations to "GetUnitAttack" and "GetUnitMagicRegen" functions:

1. 
   
2. function GetUnitItemAttackCharges takes unit v, integer itemr returns real
   
3.     local integer i = 0
   
4.     local real attack = 0.0
   
5.     loop
   
6.         if GetItemTypeId(UnitItemInSlot(v, i)) == itemr then
   
7.             set attack = attack + GetItemCharges(UnitItemInSlot(v, i))
   
8.         endif
   
9.         set i = i + 1
   
10.         exitwhen i > 6
    
11.     endloop
    
12.     return attack
    
13. endfunction
    
14. 
    
15. function GetUnitAttack takes unit v returns integer
    
16. // . . .
    
17. 
    
18.     set attack = attack + GetUnitItemAttack(v, 'I07Z', 14)
    
19.     set attack = attack + GetUnitItemAttackCharges(v, 'I07Z')
    
20. 
    
21. // . . .
    
22. endfunction
    

复制代码

1. 
   
2. function GetUnitMagicRegen takes unit v returns real
   
3. // . . .
   
4. 
   
5.     set regen = regen + GetUnitItemMagicRegen_Single(v, 'I07Z', 1.30)
   
6. 
   
7. // . . .
   
8. endfunction
   

复制代码

That's all.

香菜味沙包

that i understandT_T

my English teacher was dead Early

维琪尼亚

壓力巨大
超大
非常之大

星野航

Good job~~~~~~~~

萌之刹那

Thanks for your report